[PATCH] net: uclass: Save ethernet MAC address when generated

Wolfgang Denk wd at denx.de
Tue Nov 16 15:56:45 CET 2021


Dear Tom,

In message <20211116141855.GD24579 at bill-the-cat> you wrote:
> 
> So, to quote lib/Kconfig:
> config NET_RANDOM_ETHADDR
>         bool "Random ethaddr if unset"
>         help
>           Selecting this will allow the Ethernet interface to function
>           even when the ethaddr variable for that interface is unset.
>           A new MAC address will be generated on every boot and it will
>           not be added to the environment.

This description is at least incomplete, because it makes no
difference between the persistent copy of the environment and it's
in-memory copy.  For network to function, I think the MAC address
must be stored in the in-memory copy of the environment.

> We need either a re-spin or follow-up as we're changing the documented
> behavior.  And as I mentioned in the other thread related on-going
> thread, perhaps "ethmacskip" should play a role in preserving existing
> behavior?

We have way too many ways to do the same thing - nearly, just a
little different :-(

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"A little knowledge is a dangerous thing."                - Doug Gwyn


More information about the U-Boot mailing list