[PATCH 04/10] Convert CONFIG_PHYSMEM to Kconfig

Simon Glass sjg at chromium.org
Wed Nov 17 17:21:45 CET 2021


Hi Tom,

On Wed, 17 Nov 2021 at 08:54, Tom Rini <trini at konsulko.com> wrote:
>
> On Wed, Nov 17, 2021 at 10:46:35AM -0500, Sean Anderson wrote:
> > On 11/17/21 10:29 AM, Heinrich Schuchardt wrote:
> > > On 11/17/21 16:03, Sean Anderson wrote:
> > > > On 11/17/21 4:15 AM, Heinrich Schuchardt wrote:
> > > > > On 11/17/21 03:48, Simon Glass wrote:
> > > <snip />
> > > > > > >
> > > > > > > %s/4GB/4 GiB/
> > > > > >
> > > > > > Please let's not add that junk to U-Boot.
> > > > >
> > > > > 4GB = 4,000,000,000 bytes period.
> > > >
> > > > Only if you're a hard drive manufacturer ;)
> > >
> > > I suggest reading ISO/IEC 80000-13:2008.
> >
> > FWIW I like how truncate(1) does it:
> >
> > > Units are K,M,G,T,P,E,Z,Y (powers of 1024) or KB,MB,... (powers of
> > > 1000). Binary prefixes can be used, too: KiB=K, MiB=M, and so on.
> >
> > Which leaves the awkward units alone, and reserves the most convenient
> > suffixes for natural units.
>
> We're currently not at all consistent in Kconfig text, and I didn't
> check doc/ (where I suspect Heinrich has been enforcing consistency).
>
> I do feel like the truncate(1) method is a good compromise.

Yes I agree.

Regards,
Simon


More information about the U-Boot mailing list