[RFC PATCH] imx8m: Drop env_get_location for imx8mn and imx8mp

[Michael Nazzareno Trimarchi]

Hi ZHIZHIKIN

On Thu, Nov 18, 2021 at 7:53 PM ZHIZHIKIN Andrey
<andrey.zhizhikin at leica-geosystems.com> wrote:
>
> Hello Michael,
>
> > -----Original Message-----
> > From: U-Boot <u-boot-bounces at lists.denx.de> On Behalf Of Michael Trimarchi
> > Sent: Thursday, November 18, 2021 2:58 PM
> > To: Ye Li <ye.li at nxp.com>; Stefano Babic <sbabic at denx.de>; Fabio Estevam
> > <festevam at gmail.com>
> > Cc: u-boot at lists.denx.de; Ariel D'Alessandro <ariel.dalessandro at collabora.com>;
> > linux-amarula at amarulasolutions.com; Anthony Brandon
> > <anthony at amarulasolutions.com>
> > Subject: [RFC PATCH] imx8m: Drop env_get_location for imx8mn and imx8mp
> >
> >
> > This function defined for two architecture is not really clean
> > and can be generate problem when people add a new board
>
> Not sure what you mean by "not clean" and "can generate problems" here,
> perhaps you can elaborate that more in commit message?
>

Sorry, I will adjust the commit message. This should be done at board
level, that
would like to define the enviroment from it's own config or from some specific
setup.

> >
> > Signed-off-by: Michael Trimarchi <michael at amarulasolutions.com>
> > ---
> >  arch/arm/mach-imx/imx8m/soc.c | 42 -----------------------------------
>
> Quick git grep shows that there are boards that have it implemented,
> but only two CPU families have them:
> - arch/arm/cpu/armv8/fsl-layerscape/cpu.c
> - arch/arm/mach-imx/imx8m/soc.c
>
> - board/aristainetos/aristainetos.c
> - board/engicam/stm32mp1/stm32mp1.c
>  -board/renesas/alt/alt.c
> - board/renesas/gose/gose.c
> - board/renesas/koelsch/koelsch.c
> - board/renesas/lager/lager.c
> - board/renesas/porter/porter.c
> - board/renesas/silk/silk.c
> - board/renesas/stout/stout.c
> - board/sandbox/sandbox.c
> - board/st/stm32mp1/stm32mp1.c
> - board/sunxi/board.c
> - board/xilinx/versal/board.c
> - board/xilinx/zynq/board.c
> - board/xilinx/zynqmp/zynqmp.c
>
> If it does interfere with certain things you do - why not moving
> it to imx8mn-evk and imx8mp-evk instead? At least this would give
> adopters a hint, as EVKs are normally a reference target.

Yes, the patch is only involve the imx8mp and imx8mn.
For the problem is that make no sense to define an unique way for multiple
board. One board can boot from emmc and having env on spi flash etc

Michael
>
> -- andrey



-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael at amarulasolutions.com
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info at amarulasolutions.com
www.amarulasolutions.com