[PATCH] tools/mxsimage: Remove fclose on empty FILE pointer

Mattias Hansson hansson.mattias at gmail.com
Wed Nov 24 08:29:09 CET 2021

If `sb_load_cmdfile()` fails to open the configuration file it will jump
to error handling where the code will try to `fclose()` the FILE pointer
which is NULL causing `mkimage` to segfault.

This patch removes the `fclose()` since `fopen()` always returns NULL
instead of the file descriptor when failing.

Signed-off-by: Mattias Hansson <hansson.mattias at gmail.com>
 tools/mxsimage.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/mxsimage.c b/tools/mxsimage.c
index 002f4b525a..c7bd86ce52 100644
--- a/tools/mxsimage.c
+++ b/tools/mxsimage.c
@@ -1618,7 +1618,6 @@ static int sb_load_cmdfile(struct sb_image_ctx *ictx)
 	return 0;
-	fclose(fp);
 	fprintf(stderr, "ERR: Failed to load file \"%s\"\n",
 	return -EINVAL;

More information about the U-Boot mailing list