[PATCH v2 1/2] riscv: Support booting SiFive Unmatched from SPI.

[David Abdurachmanov]

On Wed, Nov 24, 2021 at 10:11 PM Thomas Skibo <thomas-git at skibo.net> wrote:
>
> On 11/23/21 8:39 PM, Sean Anderson wrote:
> > On 11/23/21 11:27 PM, Thomas Skibo wrote:
> >> +
> >> +
> >> +Booting from SPI
> >> +----------------
> >> +
> >> +Use Building steps from "Booting from uSD using U-Boot SPL" section.
> >> +
> >> +Partition the SPI in Linux via mtdblock.
> >> +
> >> +.. code-block:: none
> >> +
> >> +    sgdisk --clear -a 1 \
> >> +        --new=1:40:2087     --change-name=1:spl
> >> --typecode=1:5B193300-FC78-40CD-8002-E86C45580B47 \
> >> +        --new=2:2088:10279  --change-name=2:uboot
> >> --typecode=2:2E54B353-1271-4842-806F-E436D6AF6985 \
> >> +        --new=3:10280:10535 --change-name=3:env
> >> --typecode=3:0FC63DAF-8483-4772-8E79-3D69D8477DE4 \
> >
> > nit: Please use hexcodes as printed with sgdisk -L. And also document
> > what the type is. Documentation is for us humans after all :)
> >
> > --Sean
> >
>
> The first two partitions' typecodes are unique to the SiFive chip so
> they don't have a short hexcode.  The third partition, storage for the

That's correct. The 1st two are SiFive boards specific. From util-linux:

/* HiFive bootloaders */
DEF_GUID("5B193300-FC78-40CD-8002-E86C45580B47", N_("HiFive FSBL")),
DEF_GUID("2E54B353-1271-4842-806F-E436D6AF6985", N_("HiFive BBL")),

> environment, is hexcode 8300 which is a Linux filesystem.  I wonder if
> there is  better partition type for the environment.

Shouldn't this be?

"u-boot-env"      = PARTITION_U_BOOT_ENVIRONMENT
                   (3DE21764-95BD-54BD-A5C3-4ABE786F38A8)


Taken from doc/README.gpt

See:
https://github.com/u-boot/u-boot/commit/c0364ce1c6957c5295e933b95802e6966e00b08f

david

>
> I can change the typecode for the third partition and add a note about
> what the other partitions are.
>
> -Thomas
>