[RFC PATCH v3 1/8] lib: allow to build asn1 decoder and oid registry in SPL

[Simon Glass]

Hi Philippe,

On Wed, 17 Nov 2021 at 10:52, Philippe Reynes
<philippe.reynes at softathome.com> wrote:
>
> This commit adds the options:
> - SPL_ASN1_DECODER
> - SPL_OID_REGISTRY
>
> Signed-off-by: Philippe Reynes <philippe.reynes at softathome.com>
> ---
>  lib/Kconfig  | 6 ++++++
>  lib/Makefile | 7 +++++--
>  2 files changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/lib/Kconfig b/lib/Kconfig
> index 70bf8e7a46..ebff84f113 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -758,11 +758,17 @@ config ASN1_DECODER
>         help
>           Enable asn1 decoder library.
>
> +config SPL_ASN1_DECODER
> +       bool

Please add help.

While you are here could you fix up the help above? It is pretty
useless. It should mention what ASN stands for, what the library
allows and a link to some information.

> +
>  config OID_REGISTRY
>         bool
>         help
>           Enable fast lookup object identifier registry.
>
> +config SPL_OID_REGISTRY
> +       bool

help

Again that help is not very useful, please expand.

[..]

Regards,
SImon