[PATCH V2] cmd_nandbcb: Support secondary boot address of imx8mn

Fabio Estevam festevam at gmail.com
Sun Nov 28 19:00:45 CET 2021


Hi Michael,

On Sun, Nov 28, 2021 at 1:58 PM Michael Nazzareno Trimarchi
<michael at amarulasolutions.com> wrote:
>
> Hi Fabio
>
> Any time to review it?

Please fix the checkpatch warnings:

WARNING: Possible unwrapped commit description (prefer a maximum 75
chars per line)
#81:
• Secondary boot is disabled if fuse value is bigger than 10, n = fuse
value bigger than

CHECK: Unnecessary parentheses around 'plat_config.misc_flags'
#162: FILE: arch/arm/mach-imx/cmd_nandbcb.c:1540:
+ if ((plat_config.misc_flags) & FIRMWARE_SECONDARY_FIXED_ADDR) {

total: 0 errors, 1 warnings, 1 checks, 65 lines checked

I haven't personally touched arch/arm/mach-imx/cmd_nandbcb.c, so I would
like to get a review from Ye Li or Han Xu, if possible.


More information about the U-Boot mailing list