[PATCH] dt-bindings: versal: Add new PM_DEV_I2C_PMC macro

[Tom Rini]

On Tue, Nov 30, 2021 at 06:48:02PM +0100, Michal Simek wrote:
> 
> 
> On 11/30/21 17:56, Tom Rini wrote:
> > On Tue, Nov 30, 2021 at 01:56:58PM +0100, Michal Simek wrote:
> > 
> > > From: Sandeep Gundlupet Raju <sandeep.gundlupet-raju at xilinx.com>
> > > 
> > > Add new macro for PMC I2C power domain.
> > > 
> > > Signed-off-by: Sandeep Gundlupet Raju <sandeep.gundlupet-raju at xilinx.com>
> > > Signed-off-by: Michal Simek <michal.simek at xilinx.com>
> > > ---
> > > 
> > >   include/dt-bindings/power/xlnx-versal-power.h | 3 ++-
> > >   1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/include/dt-bindings/power/xlnx-versal-power.h b/include/dt-bindings/power/xlnx-versal-power.h
> > > index 1b75175edce5..4a727754ad02 100644
> > > --- a/include/dt-bindings/power/xlnx-versal-power.h
> > > +++ b/include/dt-bindings/power/xlnx-versal-power.h
> > > @@ -1,6 +1,6 @@
> > >   /* SPDX-License-Identifier: GPL-2.0 */
> > >   /*
> > > - *  Copyright (C) 2019 - 2020 Xilinx, Inc.
> > > + *  Copyright (C) 2019 - 2021 Xilinx, Inc.
> > >    */
> > >   #ifndef _DT_BINDINGS_VERSAL_POWER_H
> > > @@ -26,6 +26,7 @@
> > >   #define PM_DEV_OSPI				(0x1822402aU)
> > >   #define PM_DEV_QSPI				(0x1822402bU)
> > >   #define PM_DEV_GPIO_PMC				(0x1822402cU)
> > > +#define PM_DEV_I2C_PMC				(0x1822402dU)
> > >   #define PM_DEV_SDIO_0				(0x1822402eU)
> > >   #define PM_DEV_SDIO_1				(0x1822402fU)
> > >   #define PM_DEV_RTC				(0x18224034U)
> > 
> > So, where is this binding upstreamed, is it U-Boot specific?
> 
> I didn't push this file to upstream Linux because didn't push any versal
> specific dtsi file there yet. But this file is just IDs which are used by
> power domain driver which is upstream already.
> 
> Here you can see support for xlnx,versal-firmware driver.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/firmware/xilinx/zynqmp.c?h=v5.16-rc3#n1493
> 
> Here you can see full structure used on versal.
> 
> https://github.com/Xilinx/u-boot-xlnx/blob/master/arch/arm/dts/versal-clk.dtsi#L153

OK.  Yeah, I don't have a problem with this patch as-is, but please do
make sure it's on the TODO list to upstream this part as well.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20211130/265402de/attachment.sig>