[PATCH] rockchip: Add initial support for the PinePhone Pro

[Tom Rini]

On Tue, Nov 30, 2021 at 06:44:05PM +0000, Peter Robinson wrote:
> On Tue, Nov 30, 2021 at 5:37 PM Tom Rini <trini at konsulko.com> wrote:
> >
> > On Tue, Nov 30, 2021 at 05:47:25PM +0100, Arnaud Ferraris wrote:
> > > Hi Martijn,
> > >
> > > Thanks for this patch! It looks good overall, but I have a few minor
> > > comments regarding the defconfig, see below.
> > >
> > > Le 21/10/2021 à 19:18, Martijn Braam a écrit :
> > > > This is a new device by PINE64 that's very similar to the Pinebook Pro
> > > > that's already supported.
> > > >
> > > > Specification:
> > > > - Rockchip RK3399
> > > > - 4GB Dual-Channel LPDDR4
> > > > - 128GB eMMC
> > > > - mSD card slot
> > > > - AP6255 for 802.11ac WiFi and Bluetooth
> > > > - 6 inch 720*1440 DSI display
> > > > - Quectel EG25g usb modem
> > > > - Type-C port with alt-mode display (DP 1.2) and PD charging.
> > > >
> > > > Signed-off-by: Martijn Braam <martijn at brixit.nl>
> > > > ---
> > > >
> > > >  arch/arm/dts/Makefile                         |   1 +
> > > >  arch/arm/dts/rk3399-pinephone-pro-u-boot.dtsi |  44 ++
> > > >  arch/arm/dts/rk3399-pinephone-pro.dts         | 520 ++++++++++++++++++
> >
> > I missed the first iteration, sorry, so replying here.  For v2 please
> > note what kernel arch/arm/dts/rk3399-pinephone-pro.dts is a copy from,
> > thanks!
> 
> I'm not sure it's even been posted upstream for review, I've certainly
> not seen it.

That's a red flag over here, it needs to be in linux-next or linux
proper.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20211130/f453bd53/attachment.sig>