[PATCH u-boot-marvell v3 31/39] tools: kwboot: Fix initializing tty device

[Stefan Roese]

On 24.09.21 23:07, Marek Behún wrote:
> From: Pali Rohár <pali at kernel.org>
> 
> Retrieve current terminal settings via tcgetattr(), set to raw mode with
> cfmakeraw(), enable receiver via CREAD and ignore modem control lines
> via CLOCAL.
> 
> Signed-off-by: Pali Rohár <pali at kernel.org>
> Signed-off-by: Marek Behún <marek.behun at nic.cz>

Reviewed-by: Stefan Roese <sr at denx.de>

Thanks,
Stefan

> ---
>   tools/kwboot.c | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/kwboot.c b/tools/kwboot.c
> index d8b950787b..fc83161d70 100644
> --- a/tools/kwboot.c
> +++ b/tools/kwboot.c
> @@ -648,11 +648,12 @@ kwboot_open_tty(const char *path, int baudrate)
>   	if (fd < 0)
>   		goto out;
>   
> -	memset(&tio, 0, sizeof(tio));
> -
> -	tio.c_iflag = 0;
> -	tio.c_cflag = CREAD|CLOCAL|CS8;
> +	rc = tcgetattr(fd, &tio);
> +	if (rc)
> +		goto out;
>   
> +	cfmakeraw(&tio);
> +	tio.c_cflag |= CREAD|CLOCAL;
>   	tio.c_cc[VMIN] = 1;
>   	tio.c_cc[VTIME] = 10;
>   
> 


Viele Grüße,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de