[PATCH v2 6/6] arm: dts: ls1088a: change dwc3 compatible to match dwc3-generic driver

Michael Walle michael at walle.cc
Sun Oct 3 19:23:35 CEST 2021


> Benefit is, besides host mode, now user can choose device mode with
> setting of dr_mode = ?peripheral?;
> 
> Signed-off-by: Ran Wang <ran.wang_1 at nxp.com>
> ---
> Change in v2:
>  - Remove property 'snps,dis_rxdet_inp3_quirk' due to its side effect to Linux
>    kernel (USB device no detected) 
> 
>  arch/arm/dts/fsl-ls1088a.dtsi | 38 ++++++++++++++++++++++++++++----------
>  1 file changed, 28 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm/dts/fsl-ls1088a.dtsi b/arch/arm/dts/fsl-ls1088a.dtsi
> index 6653794..9d4f40c 100644
> --- a/arch/arm/dts/fsl-ls1088a.dtsi
> +++ b/arch/arm/dts/fsl-ls1088a.dtsi
> @@ -121,18 +121,36 @@
>  		interrupts = <0 21 0x4>; /* Level high type */
>  	};
>  
> -	usb0: usb3 at 3100000 {
> -		compatible = "fsl,layerscape-dwc3";
> -		reg = <0x0 0x3100000 0x0 0x10000>;
> -		interrupts = <0 80 0x4>; /* Level high type */
> -		dr_mode = "host";
> +	usb0: usb at 3100000 {
> +		compatible = "nxp,layerscape-dwc3";
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +		dwc3 {
> +			compatible = "snps,dwc3";
> +			reg = <0x0 0x3100000 0x0 0x10000>;
> +			interrupts = <0 80 0x4>; /* Level high type */
> +			dr_mode = "host";
> +			maximum-speed = "super-speed";
> +			snps,quirk-frame-length-adjustment = <0x20>;
> +			snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
> +		};

NAK. This is not the official device tree binding for this controller.
Please use the same binding as specified in linux.

NB. I'm working on this.

-michael


More information about the U-Boot mailing list