[PATCH u-boot-marvell v2 3/6] arm: a37xx: pci: Do not automatically enable bus mastering on PCI Bridge

Stefan Roese sr at denx.de
Fri Oct 8 08:21:22 CEST 2021


On 26.09.21 00:54, Marek Behún wrote:
> From: Pali Rohár <pali at kernel.org>
> 
> Now that PCI Bridge is working for the PCIe Root Port, U-Boot's PCI_PNP
> code automatically enables memory access and bus mastering when needed.
> 
> We do not need to enable it when setting the HW up.
> 
> Signed-off-by: Pali Rohár <pali at kernel.org>
> Reviewed-by: Marek Behún <marek.behun at nic.cz>

Reviewed-by: Stefan Roese <sr at denx.de>

Thanks,
Stefan

> ---
>   drivers/pci/pci-aardvark.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/pci/pci-aardvark.c b/drivers/pci/pci-aardvark.c
> index 692210ded9..8c025dc45d 100644
> --- a/drivers/pci/pci-aardvark.c
> +++ b/drivers/pci/pci-aardvark.c
> @@ -910,12 +910,6 @@ static int pcie_advk_setup_hw(struct pcie_advk *pcie)
>   	if (pcie_advk_wait_for_link(pcie))
>   		return -ENXIO;
>   
> -	reg = advk_readl(pcie, PCIE_CORE_CMD_STATUS_REG);
> -	reg |= PCIE_CORE_CMD_MEM_ACCESS_EN |
> -		PCIE_CORE_CMD_IO_ACCESS_EN |
> -		PCIE_CORE_CMD_MEM_IO_REQ_EN;
> -	advk_writel(pcie, reg, PCIE_CORE_CMD_STATUS_REG);
> -
>   	return 0;
>   }
>   
> 


Viele Grüße,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de


More information about the U-Boot mailing list