[PATCH] Revert "configs: stm32mp1: only support SD card after NOR in bootcmd_stm32mp"

Patrice CHOTARD patrice.chotard at foss.st.com
Fri Oct 8 08:22:15 CEST 2021


Hi Marek

On 10/4/21 1:48 PM, Marek Vasut wrote:
> This reverts commit d5d726d3cc47691ace3c68fa31147ad104aaf579,
> which breaks boards which ship with multiple SD/eMMC sockets.
> 
> This stm32mp1.h config is not used only by the ST reference
> boards, but all the other STM32MP1 based boards in U-Boot, so
> changes to this stm32mp1.h cannot break the other boards.
> 
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Patrice Chotard <patrice.chotard at foss.st.com>
> Cc: Patrick Delaunay <patrick.delaunay at foss.st.com>
> ---
> NOTE: I think we might need to split out the env for different
>       boards into different headers instead. Thoughts ?
> ---
>  include/configs/stm32mp1.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/include/configs/stm32mp1.h b/include/configs/stm32mp1.h
> index 973a4f1d4b8..a75ed693f57 100644
> --- a/include/configs/stm32mp1.h
> +++ b/include/configs/stm32mp1.h
> @@ -120,7 +120,7 @@
>   * for serial/usb: execute the stm32prog command
>   * for mmc boot (eMMC, SD card), boot only on the same device
>   * for nand or spi-nand boot, boot with on ubifs partition on UBI partition
> - * for nor boot, use SD card = mmc0
> + * for nor boot, use the default order
>   */
>  #define STM32MP_BOOTCMD "bootcmd_stm32mp=" \
>  	"echo \"Boot over ${boot_device}${boot_instance}!\";" \
> @@ -133,8 +133,6 @@
>  		"if test ${boot_device} = nand ||" \
>  		  " test ${boot_device} = spi-nand ;" \
>  		"then env set boot_targets ubifs0; fi;" \
> -		"if test ${boot_device} = nor;" \
> -		"then env set boot_targets mmc0; fi;" \
>  		"run distro_bootcmd;" \
>  	"fi;\0"
>  
> 

Applied on u-boot-stm32 for next

Thanks
Patrice


More information about the U-Boot mailing list