[PATCH v4 01/11] Revert "Revert "mkeficapsule: Remove dtb related options""
ilias.apalodimas at linaro.org
Fri Oct 8 21:11:59 CEST 2021
On Fri, Oct 08, 2021 at 09:38:11AM -0600, Simon Glass wrote:
> Hi Takahiro,
> On Thu, 7 Oct 2021 at 00:24, AKASHI Takahiro <takahiro.akashi at linaro.org> wrote:
> > This reverts commit d428e81266a59974ade74c1ba019af39f23304ab.
> > We have agreed with removing dtb-related stuff from mkeficapsule
> > command even if the commit 47a25e81d35c ("Revert "efi_capsule: Move
> > signature from DTB to .rodata"") was applied.
> Can you please explain why this is being removed? How is the public
> key to be communicated?
Via the script that Akashi-san is adding in this patch series.
> Please can you also copy me on future related patches? (thank for you
> for the private email alerting me)
> What does "We have agreed" mean?
This has nothing to do with the public key. This is only changing the tool
we used to include the key in the DTB. It is the same patch I mentioned you
should never have reverted in the first place on your pull request, but since
that happened very late in the release cycle we said we would re-apply it after
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi at linaro.org>
> > ---
> > tools/mkeficapsule.c | 229 ++-----------------------------------------
> > 1 file changed, 7 insertions(+), 222 deletions(-)
It was my patch to begin with so I am not really sure my reviewed tag has
any value, but FWIW
Reviewed-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>
More information about the U-Boot