[PATCH 1/3 v3] riscv: Remove OF_PRIOR_STAGE from RISC-V boards
Simon Glass
sjg at chromium.org
Mon Oct 11 21:20:47 CEST 2021
Hi Ilias,
On Thu, 30 Sept 2021 at 01:18, Ilias Apalodimas
<ilias.apalodimas at linaro.org> wrote:
>
> At some point back in 2018 prior_stage_fdt_address and OF_PRIOR_STAGE got
> introduced, in order to support a DTB handed over by an earlier stage boot
> loader. However we have another option in the Kconfig (OF_BOARD) which has
> identical semantics.
>
> On RISC-V some of the platforms pick up the DTB from a1 and copy it in their
> private gd_t. Apart from that they copy it to prior_stage_fdt_address, if
> the Kconfig option is selected, which is unnecessary.
>
> So let's switch the config option for those boards to OF_BOARD and define
> the required board_fdt_blob_setup() for them.
>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>
> Reviewed-by: Simon Glass <sjg at chromium.org>
> ---
> Changes since v2:
> - Adjusted board_fdt_blob_setup() for ax25-ae350 to cover OF_BOARD cases
> Changes since v1:
> - Remove the sifive unleashed/unmatched changes, since they'll be handled
> arch/riscv/cpu/cpu.c | 3 ---
> arch/riscv/cpu/start.S | 5 -----
> arch/riscv/dts/binman.dtsi | 6 +++---
> board/AndesTech/ax25-ae350/ax25-ae350.c | 7 ++++++-
> board/emulation/qemu-riscv/qemu-riscv.c | 9 +++++++++
> configs/ae350_rv32_defconfig | 2 +-
> configs/ae350_rv32_spl_defconfig | 2 +-
> configs/ae350_rv64_defconfig | 2 +-
> configs/ae350_rv64_spl_defconfig | 2 +-
> configs/qemu-riscv32_defconfig | 2 +-
> configs/qemu-riscv32_smode_defconfig | 2 +-
> configs/qemu-riscv32_spl_defconfig | 2 +-
> configs/qemu-riscv64_defconfig | 2 +-
> configs/qemu-riscv64_smode_defconfig | 2 +-
> configs/qemu-riscv64_spl_defconfig | 2 +-
> dts/Kconfig | 2 +-
> 16 files changed, 29 insertions(+), 23 deletions(-)
>
Reviewed-by: Simon Glass <sjg at chromium.org>
But please drop the extra blank line at the end of qemu-riscv.c and
wrap the commit message to 75 chars. Do you use patman to check/send
patches?
[..]
Regards,
Simon
More information about the U-Boot
mailing list