[PATCH v2 05/12] sunxi: Select SUN8I_RSB more carefully

Andre Przywara andre.przywara at arm.com
Tue Oct 12 12:47:40 CEST 2021


On Fri,  8 Oct 2021 00:17:18 -0500
Samuel Holland <samuel at sholland.org> wrote:

> SUN8I_RSB should not be selected by MACH_SUN8I, because the hardware
> is not present in half of those SoCs (H3/H5, R40, and V3s). Move the
> selection to the SoCs where the hardware actually exists.
> 
> Reviewed-by: Andre Przywara <andre.przywara at arm.com>
> Signed-off-by: Samuel Holland <samuel at sholland.org>

For the records, as per our IRC discussion, I removed the blanket select
from MACH_SUN9I, and added it to the defconfig of the two affected boards.
This fixes the compiler warnings for Sunchip_CX-A99.

Cheers,
Andre.

> ---
> 
> Changes in v2:
> - No changes
> 
>  arch/arm/mach-sunxi/Kconfig | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
> index 1d4a4fdd0c5..677d4554173 100644
> --- a/arch/arm/mach-sunxi/Kconfig
> +++ b/arch/arm/mach-sunxi/Kconfig
> @@ -260,6 +260,7 @@ config MACH_SUN8I_A23
>  	select ARCH_SUPPORT_PSCI
>  	select DRAM_SUN8I_A23
>  	select PHY_SUN4I_USB
> +	select SUN8I_RSB
>  	select SUNXI_GEN_SUN6I
>  	select SUPPORT_SPL
>  	select ARMV7_BOOT_SEC_DEFAULT if OLD_SUNXI_KERNEL_COMPAT
> @@ -273,6 +274,7 @@ config MACH_SUN8I_A33
>  	select ARCH_SUPPORT_PSCI
>  	select DRAM_SUN8I_A33
>  	select PHY_SUN4I_USB
> +	select SUN8I_RSB
>  	select SUNXI_GEN_SUN6I
>  	select SUPPORT_SPL
>  	select ARMV7_BOOT_SEC_DEFAULT if OLD_SUNXI_KERNEL_COMPAT
> @@ -283,6 +285,7 @@ config MACH_SUN8I_A83T
>  	select CPU_V7A
>  	select DRAM_SUN8I_A83T
>  	select PHY_SUN4I_USB
> +	select SUN8I_RSB
>  	select SUNXI_GEN_SUN6I
>  	select MMC_SUNXI_HAS_NEW_MODE
>  	select MMC_SUNXI_HAS_MODE_SWITCH
> @@ -377,7 +380,6 @@ endchoice
>  # The sun8i SoCs share a lot, this helps to avoid a lot of "if A23 ||
> A33" config MACH_SUN8I
>  	bool
> -	select SUN8I_RSB
>  	select SUN6I_PRCM
>  	default y if MACH_SUN8I_A23
>  	default y if MACH_SUN8I_A33



More information about the U-Boot mailing list