[PATCH v2 07/13] env: Inline env_get_char() into it's only user
sjg at chromium.org
Thu Oct 14 17:11:13 CEST 2021
On Wed, 13 Oct 2021 at 09:46, Marek Behún <kabel at kernel.org> wrote:
> From: Marek Behún <marek.behun at nic.cz>
> This function is a relic from the past when environment was read from
> underlying device one character at a time.
> It is used only in the case when getting an environemnt variable prior
> relocation, and the function is simple enough to be inlined there.
> Since env_get_char() is being changed to simple access to an array, we
> can drop the failing cases and simplify the code (this could have been
> done before, since env_get_char() did not fail even before).
> Signed-off-by: Marek Behún <marek.behun at nic.cz>
> cmd/nvedit.c | 28 ++++++++++++++--------------
> env/env.c | 8 --------
> env/nowhere.c | 5 ++---
> include/env.h | 10 ----------
> 4 files changed, 16 insertions(+), 35 deletions(-)
in subject: typo it's should be its
Reviewed-by: Simon Glass <sjg at chromium.org>
More information about the U-Boot