[PATCH v2 2/7] test: Add tests for IOMMU uclass

[Simon Glass]

Hi Mark,

On Thu, 14 Oct 2021 at 13:51, Mark Kettenis <mark.kettenis at xs4all.nl> wrote:
>
> > From: Simon Glass <sjg at chromium.org>
> > Date: Mon, 11 Oct 2021 11:00:36 -0600
> >
> > On Sun, 3 Oct 2021 at 12:31, Mark Kettenis <kettenis at openbsd.org> wrote:
> > >
> > > Add a set of tests for the IOMMU uclass.
> > >
> > > Signed-off-by: Mark Kettenis <kettenis at openbsd.org>
> > > ---
> > >  arch/sandbox/dts/test.dts          |  6 ++++++
> > >  configs/sandbox64_defconfig        |  1 +
> > >  configs/sandbox_defconfig          |  1 +
> > >  configs/sandbox_flattree_defconfig |  1 +
> > >  configs/sandbox_noinst_defconfig   |  1 +
> > >  configs/sandbox_spl_defconfig      |  1 +
> > >  drivers/iommu/Makefile             |  2 ++
> > >  drivers/iommu/sandbox_iommu.c      | 18 ++++++++++++++++++
> > >  test/dm/Makefile                   |  1 +
> > >  test/dm/iommu.c                    | 28 ++++++++++++++++++++++++++++
> > >  10 files changed, 60 insertions(+)
> > >  create mode 100644 drivers/iommu/sandbox_iommu.c
> > >  create mode 100644 test/dm/iommu.c
> > >
> >
> > Reviewed-by: Simon Glass <sjg at chromium.org>
> >
> > You could add the CONFIG options to sandbox's Kconfig in arch/Kconfig
>
> The codebase is a bit inconsistent in that respect isn't it?

Do you mean sometimes it is in defconfig and sometimes in Kconfig? Yes.

For the sandbox board, we try to enable everything
For the other boards that use the sandbox arch, we have to enable what
is needed to run tests, but not necessarily every feature

Regards,
Simon