[PATCH] tools: mksunxiboot: Use sunxi_image header directly

Samuel Holland samuel at sholland.org
Fri Oct 15 06:21:48 CEST 2021


On 10/13/21 7:19 PM, Andre Przywara wrote:
> On Tue, 12 Oct 2021 19:35:41 -0500
> Samuel Holland <samuel at sholland.org> wrote:
> 
>> When adding eGON support to mkimage, the struct boot_file_head
>> definition was moved to its own header. This is the only thing
>> mksunxiboot needed out of asm/arch/spl.h. Clean up the relative
>> include by switching to new header.
>>
>> Signed-off-by: Samuel Holland <samuel at sholland.org>
> 
> Reviewed-by: Andre Przywara <andre.przywara at arm.com>
> 
>> ---
>> We switched from using mksunxiboot to mkimage in January, so maybe
>> it is about time to consider dropping this tool?
> 
> Well, is there a reason to remove it? Otherwise I don't see a problem
> to keep it around for a while, 9 months is not a terribly long time for
> some people.

No, there's not a particular reason. I was reminded that this file still
exists because I tried refactoring some things to isolate SPL code, and
I broke it. Now that it's fixed, leaving it is not too much trouble.

Regards,
Samuel


More information about the U-Boot mailing list