[PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

[Simon Glass]

Hi Wolfgang,

On Fri, 15 Oct 2021 at 08:32, Wolfgang Denk <wd at denx.de> wrote:
>
> Dear Simon Glass,
>
> In message <20211014122254.v6.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe at changeid> you wrote:
> > At present U-Boot environment variables, and thus scripts, are defined
> > by CONFIG_EXTRA_ENV_SETTINGS. It is painful to add large amounts of text
> > to this file and dealing with quoting and newlines is harder than it
> > should be. It would be better if we could just type the script into a
> > text file and have it included by U-Boot.
> >
> > Add a feature that brings in a .env file associated with the board
> > config, if present. To use it, create a file in a board/<vendor>/env
> > directory called <board>.env (or common.env if you want the same
> > environment for all boards).
>
> Argh... did you bother to read my comments?  Apparently not.
>
> Thus:
>
> NAKed by: Wolfgang Denk <wd at denx.de>
>
>
> I really think your fixed filename proposal does not work well in
> reality.  The file name should be Kconfig configurable. See [1]
> for details.
>
> [1] https://lists.denx.de/pipermail/u-boot/2021-October/462668.html

Yes I saw that but I forgot to look at it. I think it makes sense - we
do that with devicetree, for example.

Is that the only thing holding you back? I haven't seen any positive
comments to this series yet...

Regards,
Simon