[EXT] Re: [PATCH v3 01/16] crypto/fsl: Add support for CAAM Job ring driver model

[Gaurav Jain]

Hi Simon

> -----Original Message-----
> From: Simon Glass <sjg at chromium.org>
> Sent: Thursday, October 14, 2021 8:40 PM
> To: Gaurav Jain <gaurav.jain at nxp.com>
> Cc: U-Boot Mailing List <u-boot at lists.denx.de>; Stefano Babic
> <sbabic at denx.de>; Fabio Estevam <festevam at gmail.com>; Peng Fan
> <peng.fan at nxp.com>; Priyanka Jain <priyanka.jain at nxp.com>; Ye Li
> <ye.li at nxp.com>; Horia Geanta <horia.geanta at nxp.com>; Ji Luo
> <ji.luo at nxp.com>; Franck Lenormand <franck.lenormand at nxp.com>; Silvano Di
> Ninno <silvano.dininno at nxp.com>; Sahil Malhotra <sahil.malhotra at nxp.com>;
> Pankaj Gupta <pankaj.gupta at nxp.com>; Varun Sethi <V.Sethi at nxp.com>; dl-
> uboot-imx <uboot-imx at nxp.com>; Shengzhou Liu <shengzhou.liu at nxp.com>;
> Mingkai Hu <mingkai.hu at nxp.com>; Rajesh Bhagat <rajesh.bhagat at nxp.com>;
> Meenakshi Aggarwal <meenakshi.aggarwal at nxp.com>; Wasim Khan
> <wasim.khan at nxp.com>; Alison Wang <alison.wang at nxp.com>; Pramod
> Kumar <pramod.kumar_1 at nxp.com>; Andy Tang <andy.tang at nxp.com>;
> Adrian Alonso <adrian.alonso at nxp.com>; Vladimir Oltean <olteanv at gmail.com>
> Subject: [EXT] Re: [PATCH v3 01/16] crypto/fsl: Add support for CAAM Job ring
> driver model
> 
> Caution: EXT Email
> 
> Hi,
> 
> On Mon, 4 Oct 2021 at 23:40, Gaurav Jain <gaurav.jain at nxp.com> wrote:
> >
> > added device tree support for job ring driver.
> > sec is initialized based on job ring information processed from device
> > tree.
> >
> > Signed-off-by: Gaurav Jain <gaurav.jain at nxp.com>
> > Reviewed-by: Ye Li <ye.li at nxp.com>
> > ---
> >  cmd/Kconfig                 |   1 +
> >  drivers/crypto/fsl/Kconfig  |   7 +
> >  drivers/crypto/fsl/Makefile |   3 +-
> >  drivers/crypto/fsl/jr.c     | 318 ++++++++++++++++++++++++------------
> >  drivers/crypto/fsl/jr.h     |  14 ++
> >  5 files changed, 233 insertions(+), 110 deletions(-)
> 
> This does not look like a proper driver to me, as it has an exported function
> sec_init_idx().
> 
> What operations does it perform? Should it have a uclass?
> 
> Regards,
> Simon

For majority of platforms driver model is followed.
But due to memory constraints with few platforms, driver model cannot be implemented on SPL.
so to enable caam on such platforms we are using non DM approach( via sec_init_idx() ).

sec_init_idx() perform tasks that are required for CAAM to work.
caam reset, caam initialization, job ring initialization, RNG instantiation.

Regards
Gaurav Jain