[PATCH 1/1] board: sifive: unmatched: enlarge CONFIG_SYS_SPL_MALLOC_SIZE

[Alexandre Ghiti]

On Tue, Oct 19, 2021 at 10:55 AM Bin Meng <bmeng.cn at gmail.com> wrote:
>
> On Tue, Oct 19, 2021 at 4:32 PM Alexandre Ghiti
> <alexandre.ghiti at canonical.com> wrote:
> >
> > Hi,
> >
> > On Fri, Oct 1, 2021 at 5:35 PM Bin Meng <bmeng.cn at gmail.com> wrote:
> > >
> > > Hi Heinrich,
> > >
> > > On Fri, Oct 1, 2021 at 7:37 PM Heinrich Schuchardt
> > > <heinrich.schuchardt at canonical.com> wrote:
> > > >
> > > > Avoid an error like
> > > >
> > > >     Could not get FIT buffer of 1725952 bytes
> > > >             check CONFIG_SYS_SPL_MALLOC_SIZE
> > > >     No device tree specified in SPL image
> > > >     ### ERROR ### Please RESET the board ###
> > > >
> > > > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> > > > ---
> > > >  include/configs/sifive-unmatched.h | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/include/configs/sifive-unmatched.h b/include/configs/sifive-unmatched.h
> > > > index f8ad2cce1f..8d3deabdd3 100644
> > > > --- a/include/configs/sifive-unmatched.h
> > > > +++ b/include/configs/sifive-unmatched.h
> > > > @@ -18,7 +18,7 @@
> > > >  #define CONFIG_SPL_BSS_MAX_SIZE                0x00100000
> > > >  #define CONFIG_SYS_SPL_MALLOC_START    (CONFIG_SPL_BSS_START_ADDR + \
> > > >                                          CONFIG_SPL_BSS_MAX_SIZE)
> > > > -#define CONFIG_SYS_SPL_MALLOC_SIZE     0x00100000
> > > > +#define CONFIG_SYS_SPL_MALLOC_SIZE     0x00200000
> > > >
> > > >  #define CONFIG_SPL_STACK       (0x08000000 + 0x001D0000 - \
> > > >                                  GENERATED_GBL_DATA_SIZE)
> > >
> > > What caused this?
> > >
> > > Last time this was seen on Ax25-AE350, CONFIG_SPL_SYS_MALLOC_F_LEN was
> > > increased, instead of CONFIG_SYS_SPL_MALLOC_SIZE which the error
> > > messages point to
> > >
> > > https://lists.denx.de/pipermail/u-boot/2021-May/449447.html
> > >
> >
> > I fell into the same issue this morning and increasing
> > CONFIG_SYS_SPL_MALLOC_SIZE fixed it, though I had to increase it even
> > more than Heinrich.
>
> Is this default build that caused Unmatched boot failure?

Yes but I made a mistake as I used openSBI fw_payload.bin instead of
fw_dymanic.bin and the fw_payload.bin is ~2MB against 74K for the
fw_dynamic.bin.

Sorry about that!

Alex

>
> @Rick Chen  can you comment on why CONFIG_SPL_SYS_MALLOC_F_LEN was
> needed on AE350?
>
> Regards,
> Bin