[PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

[Simon Glass]

Hi Tom,

On Thu, 21 Oct 2021 at 10:03, Tom Rini <trini at konsulko.com> wrote:
>
> On Thu, Oct 21, 2021 at 09:59:38AM -0600, Simon Glass wrote:
> > Hi Marek,
> >
> > On Thu, 21 Oct 2021 at 07:28, Marek Behún <marek.behun at nic.cz> wrote:
> > >
> > > On Thu, 21 Oct 2021 15:25:37 +0200
> > > Marek Behún <marek.behun at nic.cz> wrote:
> > >
> > > > Hello,
> > > >
> > > > On Thu, 21 Oct 2021 15:06:51 +0200
> > > > Wolfgang Denk <wd at denx.de> wrote:
> > > >
> > > > > I confirm that '+=' looks better.  But '+=" is technically broken.
> > > >
> > > > a bit of my opinion:
> > > > I think =+ will confuse far more people than + as last character of var
> > > > name working weirdly. But I also think that + should be supported as
> > > > last character. Therefore I propose backslash escaping in variable name,
> > > > i.e.
> > > >   var+=value
> > > > appends value to var, while
> > > >   var\+=value
> > > > sets variable with name "var+"
> >
> > My first preference is to disallow + at the end of an end var. Perhaps
> > we can start printing a warning if people do it, for a few releases.
> >
> > My distance second preference is what Marek has here, using a
> > backslash to escape the + character.
>
> How bad does it make the parser look if we allow trailing + in variable
> names, by escaping them?  It's seemingly the substantive objection at
> this point.

I'm pretty sure we can do it easily enough. I'll take a look when I
get back to this.

Regards,
Simon