[PATCH 4/4] mmc: sunxi: Use DM_GPIO flags to set pull-up

[Andre Przywara]

On Fri, 22 Oct 2021 06:58:48 +0900
Jaehoon Chung <jh80.chung at samsung.com> wrote:

Hi Jaehoon,

thanks for having a look!

> Hi,
> 
> On 10/21/21 1:52 PM, Samuel Holland wrote:
> > Now that the sunxi_gpio driver handles pull-up/down via the driver
> > model, pin configuration does not need a platform-specific function.
> > 
> > Signed-off-by: Samuel Holland <samuel at sholland.org>
> > ---
> > 
> >  drivers/mmc/sunxi_mmc.c | 8 ++------
> >  1 file changed, 2 insertions(+), 6 deletions(-)
> > 
> > diff --git a/drivers/mmc/sunxi_mmc.c b/drivers/mmc/sunxi_mmc.c
> > index c170c16d5a..955b29826f 100644
> > --- a/drivers/mmc/sunxi_mmc.c
> > +++ b/drivers/mmc/sunxi_mmc.c
> > @@ -700,12 +700,8 @@ static int sunxi_mmc_probe(struct udevice *dev)
> >  		return ret;
> >  
> >  	/* This GPIO is optional */
> > -	if (!gpio_request_by_name(dev, "cd-gpios", 0, &priv->cd_gpio,
> > -				  GPIOD_IS_IN)) {
> > -		int cd_pin = gpio_get_number(&priv->cd_gpio);
> > -
> > -		sunxi_gpio_set_pull(cd_pin, SUNXI_GPIO_PULL_UP);
> > -	}
> > +	gpio_request_by_name(dev, "cd-gpios", 0, &priv->cd_gpio,
> > +			     GPIOD_IS_IN | GPIOD_PULL_UP);  
> 
> Is it right to set the pull-up?

You mean, unconditionally? I mean it's just copying the current
code, which does that (see the "minus" lines just above).

But I think you have a point: I don't see any pull up specified in any DT,
and I think most (if not all) boards have a discrete pull up resistor on
that line.

But I don't dare to touch that code - at least for this series, as it
works (TM) right now.
After the full DM_PINCTRL series this might be another story, though.

Cheers,
Andre

> 
> Best Regards,
> Jaehoon Chung
> 
> >  
> >  	upriv->mmc = &plat->mmc;
> >  
> >   
>