[PATCH v6 7/7] bootm: Tidy up use of autostart env var

Simon Glass sjg at chromium.org
Sun Oct 24 21:53:43 CEST 2021


Hi Wolfgang,

On Fri, 15 Oct 2021 at 08:45, Wolfgang Denk <wd at denx.de> wrote:
>
> Dear Simon Glass,
>
> In message <20211014182257.468649-6-sjg at chromium.org> you wrote:
> > This has different semantics in different places. Go with the bootm method
> > and put it in a common function so that the behaviour is consistent in
> > U-Boot. Update the docs.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > Suggested-by: Wolfgang Denk <wd at denx.de>
>
> It should be noted that this commit changes the behaviour of U-Boot
> for "autostart" users, thus it has the potential of breaking
> existent systems.
>
> The problematic cases are in do_bootelf() [cmd/elf.c] and
> do_bootm_standalone() [common/bootm_os.c]; the 3rd place where this
> is used - bootm_maybe_autostart() [cmd/bootm.c] - does not change.
>
> Or am I missing something?

Just to reply here, I sent an updated patch explaining that this does
in fact change behaviour, but only in a case that seems safe enough.

Regards,
Simon


More information about the U-Boot mailing list