[PATCH v2 2/2] cmd: brcm: netXtreme commands

[Marek Behún]

On Fri, 22 Oct 2021 16:23:33 -0700
Roman Bacik <roman.bacik at broadcom.com> wrote:

> From: Bharat Gooty <bharat.gooty at broadcom.com>
> 
> Following netXtreme commands are supported:-
> Device probe, remove, supported speeds, get/set speeds and
> get/set MAC address.

NAK.

- "bnxt <bnxt_eth#> get mac

  U-Boot uses the ethaddr and ethNaddr environment variables for MAC
  addresses. You don't need a new custom command for that when there is
  a generic mechanism for this.

- "<bnxt_eth#> probe" / "<bnxt_eth#> remove"

  You also shouldn't need a command for driver probe / remove. DM should
  probe your driver automatically. And if you need it for debugging,
  please add such subcommand to the dm command.

- "bnxt <bnxt_eth#> get supported_speed"
  "bnxt <bnxt_eth#> get link_speed"

  These should be available via the mdio command when you register your
  PHY driver via appropriate API.

Marek