[PATCH v2 1/2] net: brcm: netXtreme driver

[Roman Bacik]

On Mon, Oct 25, 2021 at 3:22 PM Marek Behún <kabel at kernel.org> wrote:
>
> On Mon, 25 Oct 2021 14:35:20 -0700
> Roman Bacik <roman.bacik at broadcom.com> wrote:
>
> > > - you are introducing custom mechanism for setting / getting PHY
> > >   parameters, via custom specific env variables, for example in the
> > >   set_phy_speed() and set_phy_link() functions, i.e.:
> > >         sprintf(name1, "bnxt_eth%u_phy_speed", bp->cardnum);
> > >         env_set(name1, name);
> > >
> > >   The whole point of several people in the past few years was to create
> > >   generic mechanisms for such things. We have ethernet PHY DM class,
> > >   you should use this. That way you won't need to introduce custom
> > >   mechanisms to get the infromation, since there are mii/mdio commands.
> >
> > These are chip internal settings stored internally in NVM. They are
> > not modified via mii/mdio.
>
> Ah. Well that also shouldn't use custom commands. Unfortunately U-Boot
> does not have a generic nvmem API yet, but I plan to write nvmem API
> together with `nvmem` command, which would be generic.
>
> As of now, we have the `mac` and `fuse` commands for this (although
> deprecated and will be removed). If you want to write nvmem interface,
> you could use the `mac` command. But it will be deprecated once we have
> nvmem API, would you be willing to rewrite it then?
>
> Marek

Hi Marek,

We will remove get/set mac/speed for now, since we have a workaround.
Thanks,

Roman

-- 
This electronic communication and the information and any files transmitted 
with it, or attached to it, are confidential and are intended solely for 
the use of the individual or entity to whom it is addressed and may contain 
information that is confidential, legally privileged, protected by privacy 
laws, or otherwise restricted from disclosure to anyone else. If you are 
not the intended recipient or the person responsible for delivering the 
e-mail to the intended recipient, you are hereby notified that any use, 
copying, distributing, dissemination, forwarding, printing, or copying of 
this e-mail is strictly prohibited. If you received this e-mail in error, 
please return the e-mail to the sender, delete it from your computer, and 
destroy any printed copy of it.