[PATCH 6/6] scripts: remove CONFIG_IS_ENABLED in config_whitelist.txt

Simon Glass sjg at chromium.org
Tue Oct 26 05:29:29 CEST 2021


Hi Patrick,

On Fri, 22 Oct 2021 at 11:13, Patrick DELAUNAY
<patrick.delaunay at foss.st.com> wrote:
>
> Hi Simon
>
> On 10/14/21 5:09 PM, Simon Glass wrote:
> > Hi Patrick,
> >
> > On Mon, 4 Oct 2021 at 04:00, Patrick Delaunay
> > <patrick.delaunay at foss.st.com> wrote:
> >> Redefine the macro CONFIG_IS_ENABLED is not allowed,
> >> so this entry can be removed in whitelist file.
> >>
> >> Signed-off-by: Patrick Delaunay <patrick.delaunay at foss.st.com>
> >> ---
> >>
> >>   scripts/config_whitelist.txt | 1 -
> >>   1 file changed, 1 deletion(-)
> >>
> >> diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt
> >> index b3ebd20c57..41a0952c97 100644
> >> --- a/scripts/config_whitelist.txt
> >> +++ b/scripts/config_whitelist.txt
> >> @@ -649,7 +649,6 @@ CONFIG_IRAM_SIZE
> >>   CONFIG_IRAM_STACK
> >>   CONFIG_IRAM_TOP
> >>   CONFIG_IRDA_BASE
> >> -CONFIG_IS_ENABLED
> >>   CONFIG_JFFS2_DEV
> >>   CONFIG_JFFS2_LZO
> >>   CONFIG_JFFS2_NAND
> >> --
> >> 2.25.1
> >>
> > For this to work you need to actually remove it from the source tree
> > (which we can't), otherwise you get:
> >
> > Error: You must add new CONFIG options using Kconfig
> > The following new ad-hoc CONFIG options were detected:
> > CONFIG_IS_ENABLED
> >
> > I don't think this is worth it though, so I suggest dropping this patch.
> >
> > Regards,
> > Simon
>
>
> Yes ! sorry
>
> CONFIG_IS_ENABLED is present in u-boot.cfg,
>
> as CONFIG_VAL
>
>
> even if it is strange for these macro defined in "linux/kconfig.h"
>
> but agree to drop this tentative.
>
>
> Do you think I can remove the CONFIG_IS_ENABLED and CONFIG_VAL
>
> in u-boot.cfg when the file is generated ?

If you like.

Regards,
Simon


More information about the U-Boot mailing list