[PATCH v2 07/41] mbr: Correct verification check

[Ilias Apalodimas]

Hi Simon,

On Sat, Oct 23, 2021 at 05:26:01PM -0600, Simon Glass wrote:
> At present this command considers the partitions to be identical if the
> start and size are smaller than expected. It should check that they are
> the same. Fix this and tidy up the code style a little.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
> 
> (no changes since v1)
> 
>  cmd/mbr.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/cmd/mbr.c b/cmd/mbr.c
> index e7e22980969..c269833eb82 100644
> --- a/cmd/mbr.c
> +++ b/cmd/mbr.c
> @@ -244,12 +244,12 @@ static int do_verify_mbr(struct blk_desc *dev, const char *str)
>  	for (i = 0; i < count; i++) {
>  		struct disk_partition p;
>  
> -		if (part_get_info(dev, i+1, &p))
> +		if (part_get_info(dev, i + 1, &p))
>  			goto fail;
>  
> -		if ((partitions[i].size && p.size < partitions[i].size) ||
> -		    (partitions[i].start && p.start < partitions[i].start) ||
> -		    (p.sys_ind != partitions[i].sys_ind))
> +		if ((partitions[i].size && p.size != partitions[i].size) ||
> +		    (partitions[i].start && p.start != partitions[i].start) ||
> +		    p.sys_ind != partitions[i].sys_ind)
>  			goto fail;
>  	}
>  	ret = 0;
> -- 
> 2.33.0.1079.g6e70778dc9-goog
> 

This seems irrelevant to the series and a general fix. Can you send it as
such?

Acked-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>