[PATCH v1 1/2] x86: tangier: Enable support for SD/SDIO family in the pinmux driver

Andy Shevchenko andy.shevchenko at gmail.com
Wed Oct 27 10:53:49 CEST 2021


On Wed, Oct 27, 2021 at 5:49 AM Bin Meng <bmeng.cn at gmail.com> wrote:
> On Sat, Oct 16, 2021 at 1:27 AM Andy Shevchenko
> <andriy.shevchenko at linux.intel.com> wrote:
> >
> > We would need to quirk out Card Detect case and for that we allow
> > configuring SD/SDIO family of pins.

...

> > +static int mrfld_pinconfig(unsigned int pin, u32 mask, u32 bits)
> > +{

> This function can be consolidated with mrfld_pinconfig_protected(),
> ie: updating mrfld_pinconfig_protected() to call mrfld_pinconfig().

Can it be done in a separate patch? This is a fix related and tested,
it will take time to retest this by all parties.

> > +}

-- 
With Best Regards,
Andy Shevchenko


More information about the U-Boot mailing list