[PATCH 1/4] sysreset: Add uclass Kconfig dependency to drivers

Heinrich Schuchardt heinrich.schuchardt at canonical.com
Wed Oct 27 12:05:03 CEST 2021


On 8/22/21 22:41, Samuel Holland wrote:
> The drivers enabled by SYSRESET_SYSCON, SYSRESET_WATCHDOG, and
> SYSRESET_RESETCTL do nothing beyond providing sysreset uclass ops.
> Therefore, they should depend on the sysreset uclass.
> 
> Signed-off-by: Samuel Holland <samuel at sholland.org>
> ---
> 
>   drivers/sysreset/Kconfig | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/sysreset/Kconfig b/drivers/sysreset/Kconfig
> index ac77ffbc8be..fdc858ccbac 100644
> --- a/drivers/sysreset/Kconfig
> +++ b/drivers/sysreset/Kconfig
> @@ -106,8 +106,6 @@ config SYSRESET_TI_SCI
>   	  This enables the system reset driver support over TI System Control
>   	  Interface available on some new TI's SoCs.
>   
> -endif
> -
>   config SYSRESET_SYSCON
>   	bool "Enable support for mfd syscon reboot driver"
>   	select REGMAP
> @@ -127,6 +125,8 @@ config SYSRESET_RESETCTL
>   	help
>   	  Reboot support using generic reset controller.
>   
> +endif
> +

All sysreset drivers in directory drivers/sysreset/ require 
sysreset-uclass.o. Please, move this endif to the very end of the 
Kconfig file.

Best regards

Heinrich

>   config SYSRESET_X86
>   	bool "Enable support for x86 processor reboot driver"
>   	depends on X86
> 



More information about the U-Boot mailing list