[PATCH v3 01/35] efi: Add a script for building and testing U-Boot on UEFI

[Heinrich Schuchardt]

On 10/28/21 16:19, Simon Glass wrote:
> Hi Heinrich,
>
> On Wed, 27 Oct 2021 at 23:38, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>>
>> On 10/26/21 5:30 AM, Simon Glass wrote:
>>> It is quite complicated to run U-Boot on QEMU since we have four
>>> different builds and they must use different versions of qemu and the
>>> UEFI binaries.
>>>
>>> Add a script to help.
>>>
>>> Signed-off-by: Simon Glass <sjg at chromium.org>
>>
>> It seems that you missed some of my review comments:
>>
>> * The script does not work:
>>
>> $ scripts/build-efi.sh -wsPr
>> Packaging efi-x86_app32
>> [sudo] password for user:
>> cp: cannot stat '/tmp/b//efi-x86_app32/u-boot-app.efi': No such file or
>> directory
>>
>> * Do not use fixed directories in /tmp but use 'mktemp -d' to create a
>> unique directory.
>
> Did you see my response when you asked about that last time? To
> repeat, you need to build U-Boot somewhere and have a build directory.
> If this script creates a tmpdir, what is the point? We still need the
> build dir.

The title of this patch is: "Add a script for *building and testing*
U-Boot on UEFI"

I can't it see building.

Best regards

Heinrich

>
> Also:
>
>>> +# Set ubdir to the build directory where you build U-Boot out-of-tree
>>> +# We avoid in-tree build because it gets confusing trying different builds
>
>
> Also documented at the very top of the script:
>
> [..]
>
>
>>> +# Script to build an EFI thing suitable for booting with QEMU, possibly running
>>> +# it also.
>>> +
>>> +# This just an example. It assumes that
>>> +
>>> +# - you build U-Boot in ${ubdir}/<name> where <name> is the U-Boot board config
>>> +# - /mnt/x is a directory used for mounting
>>> +# - you have access to the 'pure UEFI' builds for QEMU
>>> +#
>>> +# UEFI binaries for QEMU used for testing this script:
>>> +#
>>> +# OVMF-pure-efi.i386.fd at
>>> +# https://drive.google.com/file/d/1jWzOAZfQqMmS2_dAK2G518GhIgj9r2RY/view?usp=sharing
>>> +
>>> +# OVMF-pure-efi.x64.fd at
>>> +# https://drive.google.com/file/d/1c39YI9QtpByGQ4V0UNNQtGqttEzS-eFV/view?usp=sharing
>>> +
>
> Regards,
> Simon
>