[PATCH 5/5] arm: mvebu: Espressobin: Use new API for setting default env at runtime

Simon Glass sjg at chromium.org
Fri Oct 29 05:17:42 CEST 2021


Hi Marek,

On Wed, 27 Oct 2021 at 21:28, Marek Behún <kabel at kernel.org> wrote:
>
> From: Marek Behún <marek.behun at nic.cz>
>
> ESPRESSObin's board code uses an ad-hoc solution for ensuring that
> ethaddrs are not overwritten by `env default -a` command and that the
> `fdtfile` is set to correct value when `env default -a` is called.
>
> This ad-hoc solution is overwriting the default_environment[] buffer in
> board_late_init().
>
> Since now we have a specific API for overwriting default environment,
> convert this ad-hoc code to this new API.
>
> Since the default_environment[] buffer is not overwritten anymore by any
> board, remove support for read-write default_environment[].
>
> Signed-off-by: Marek Behún <marek.behun at nic.cz>
> ---
>  board/Marvell/mvebu_armada-37xx/board.c     | 120 ++++++++++++--------
>  configs/mvebu_espressobin-88f3720_defconfig |   1 -
>  include/configs/mvebu_armada-37xx.h         |  17 +--
>  include/env_default.h                       |   2 -
>  include/env_internal.h                      |   4 -
>  5 files changed, 75 insertions(+), 69 deletions(-)

Can you split out the generic changes into their own patch?

Regards,
Simon


More information about the U-Boot mailing list