[PATCH 3/5] dm: rtc: Avoid a race in the rtc_reset test

Simon Glass sjg at chromium.org
Mon Aug 1 15:58:46 CEST 2022


Since resetting the RTC on sandbox causes it to read the base time from
the system, we cannot rely on this being unchanged since it was last read.
Allow for a one-second delay.

Reviewed-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
Fixes: https://source.denx.de/u-boot/u-boot/-/issues/4
Reported-by: Bin Meng <bmeng.cn at gmail.com>
Reported-by: Tom Rini <trini at konsulko.com>
Suggested-by: Rasmus Villemoes <rasmus.villemoes at prevas.dk>
Signed-off-by: Simon Glass <sjg at chromium.org>
---

 test/dm/rtc.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/test/dm/rtc.c b/test/dm/rtc.c
index a8349756c18..e23905b3e2e 100644
--- a/test/dm/rtc.c
+++ b/test/dm/rtc.c
@@ -251,10 +251,15 @@ static int dm_test_rtc_reset(struct unit_test_state *uts)
 
 	ut_asserteq(0, sandbox_i2c_rtc_get_set_base_time(emul, -1));
 
-	/* Resetting the RTC should put he base time back to normal */
+	/*
+	 * Resetting the RTC should put the base time back to normal. Allow for
+	 * a one-second adjustment in case the time flips over while this
+	 * test process is pre-empted, since reset_time() in i2c_rtc_emul.c
+	 * reads the time from the OS.
+	 */
 	ut_assertok(dm_rtc_reset(dev));
 	base_time = sandbox_i2c_rtc_get_set_base_time(emul, -1);
-	ut_asserteq(old_base_time, base_time);
+	ut_assert(base_time - old_base_time <= 1);
 
 	return 0;
 }
-- 
2.37.1.455.g008518b4e5-goog



More information about the U-Boot mailing list