[PATCH 1/2] Makefile: Fix dependency for u-boot-with-dtb.bin

Simon Glass sjg at chromium.org
Mon Aug 1 21:13:21 CEST 2022


On Mon, 1 Aug 2022 at 09:43, Pali Rohár <pali at kernel.org> wrote:
>
> Makefile uses binman to produce u-boot-with-dtb.bin target. As its input it
> takes DTB file and u-boot binary without DTB, which is stored in file
> u-boot-nodtb.bin. So fix target dependency.
>
> Signed-off-by: Pali Rohár <pali at kernel.org>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index ff25f9297486..dcfcd7ebd5d2 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1628,7 +1628,7 @@ u-boot-with-nand-spl.sfp: u-boot-spl-padx4.sfp u-boot.img FORCE
>  endif
>
>  ifeq ($(CONFIG_MPC85xx)$(CONFIG_OF_SEPARATE),yy)
> -u-boot-with-dtb.bin: u-boot.bin u-boot.dtb \
> +u-boot-with-dtb.bin: u-boot-nodtb.bin u-boot.dtb \
>         $(if $(CONFIG_MPC85XX_HAVE_RESET_VECTOR), u-boot-br.bin) FORCE
>         $(call if_changed,binman)
>
> --
> 2.20.1
>

Reviewed-by: Simon Glass <sjg at chromium.org>

But I feel this should be dropped and be handled by the normal binman
rule in the Makefile.


More information about the U-Boot mailing list