Broken commit de47ff536363289f92f85ed1e4901724d238432d

[Pali Rohár]

Hello Tom!

Your commit de47ff536363289f92f85ed1e4901724d238432d ("Convert
CONFIG_SYS_MPC85XX_NO_RESETVEC to Kconfig") seems to be broken.

If you look at P1020RDB-PD_defconfig file change in this commit there is:

--- a/configs/P1020RDB-PD_defconfig
+++ b/configs/P1020RDB-PD_defconfig
@@ -9,6 +9,7 @@ CONFIG_MPC85xx=y
 # CONFIG_CMD_ERRATA is not set
 CONFIG_TARGET_P1020RDB_PD=y
 CONFIG_MPC85XX_HAVE_RESET_VECTOR=y
+CONFIG_SYS_MPC85XX_NO_RESETVEC=y
 CONFIG_MP=y
 CONFIG_FIT=y
 CONFIG_FIT_VERBOSE=y

Which does not make sense to me.

First thing is that CONFIG_MPC85XX_HAVE_RESET_VECTOR and
CONFIG_SYS_MPC85XX_NO_RESETVEC are exclusive options. You can either
disable generating of reset vector in image or enable it. What is
expected from the result when you ask Kconfig to both enable and disable
it? First specified option win? Or last specified win? Or random of
those two options win? It is not really clear for me.

Second thing is that reset vector is required for (parallel) NOR booting
and your change is adding CONFIG_SYS_MPC85XX_NO_RESETVEC=y to defconfig
for NOR, which to my guess make image non-bootable and broken.

And seems that other defconfig files in that change have similar issues.