[PATCH 1/5] arm: mvebu: a7040/a8040/cn9130: Add spi0 dts reference

[Stefan Roese]

On 03.08.22 13:00, Pali Rohár wrote:
> For future changes it is needed for have spi0 device tree reference in
> every mvebu soc dts file even when it is unused.
> 
> Signed-off-by: Pali Rohár <pali at kernel.org>
> ---
>   arch/arm/dts/armada-7040.dtsi | 3 +++
>   arch/arm/dts/armada-8040.dtsi | 3 +++
>   arch/arm/dts/cn9130.dtsi      | 3 +++
>   3 files changed, 9 insertions(+)

You're changing 64-bit Armada files here, but in the cover letter you
mention that this patchset only addresses 32-bit mvebu DT files. So
why are you making these changes here?

One more comment below...

> diff --git a/arch/arm/dts/armada-7040.dtsi b/arch/arm/dts/armada-7040.dtsi
> index 039d30c72a8c..1fb21c6bfde0 100644
> --- a/arch/arm/dts/armada-7040.dtsi
> +++ b/arch/arm/dts/armada-7040.dtsi
> @@ -63,3 +63,6 @@
>   		marvell,function = <3>;
>   	};
>   };
> +
> +spi0: &cp0_spi1 {
> +};

Why is spi0 aliased now to "cp0_spi1"? In the Kernel DT files I see
this:

		spi0 = &spi0;
		spi1 = &cp0_spi0;
		spi2 = &cp0_spi1;
...
			spi0: spi at 510600 {

Thanks,
Stefan

> diff --git a/arch/arm/dts/armada-8040.dtsi b/arch/arm/dts/armada-8040.dtsi
> index eec5fa277405..608ff0d97f95 100644
> --- a/arch/arm/dts/armada-8040.dtsi
> +++ b/arch/arm/dts/armada-8040.dtsi
> @@ -87,3 +87,6 @@
>   		marvell,function = <3>;
>   	};
>   };
> +
> +spi0: &cp1_spi1 {
> +};
> diff --git a/arch/arm/dts/cn9130.dtsi b/arch/arm/dts/cn9130.dtsi
> index 68b767a70639..a200276f7a2e 100644
> --- a/arch/arm/dts/cn9130.dtsi
> +++ b/arch/arm/dts/cn9130.dtsi
> @@ -71,3 +71,6 @@
>   		marvell,function = <3>;
>   	};
>   };
> +
> +spi0: &cp0_spi1 {
> +};

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de