[PATCH] disk: part: remove dependency to ubifs for spl

Stefan Herbrechtsmeier stefan.herbrechtsmeier-oss at weidmueller.com
Tue Aug 9 09:27:35 CEST 2022


Hi Simon,

Am 08.08.2022 um 21:26 schrieb Simon Glass:
> Hi Stefan,
> 
> On Mon, 8 Aug 2022 at 08:45, Stefan Herbrechtsmeier
> <stefan.herbrechtsmeier-oss at weidmueller.com> wrote:
>>
>> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier at weidmueller.com>
>>
>> The spl doesn't support ubifs and thereby doesn't provide the
>> ubifs_is_mounted function. Remove the dependency to ubifs for the spl.
>>
>> Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier at weidmueller.com>
>>
>> ---
>>
>>   disk/part.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/disk/part.c b/disk/part.c
>> index 79955c7fb0..de1b917e84 100644
>> --- a/disk/part.c
>> +++ b/disk/part.c
>> @@ -479,7 +479,7 @@ int blk_get_device_part_str(const char *ifname, const char *dev_part_str,
>>          }
>>   #endif
>>
>> -#ifdef CONFIG_CMD_UBIFS
>> +#if IS_ENABLED(CONFIG_CMD_UBIFS) && !IS_ENABLED(CONFIG_SPL_BUILD)
>>          /*
>>           * Special-case ubi, ubi goes through a mtd, rather than through
>>           * a regular block device.
>> --
>> 2.30.2
>>
> 
> A CMD config should not be used outside cmd/ - can we add a proper
> CONFIG_UBIFS ?

The code use the ubifs_is_mounted function from cmd/ubifs.c file and 
reference the ubifsmount command from the same file. The 
drivers/misc/fs_loader.c and fs/fs.c files use functions from the 
cmd/ubifs.c file too.


Regards
   Stefan


More information about the U-Boot mailing list