[PATCH] misc: atsha204a: Don't check for error when waking up the device

Marek Behún kabel at kernel.org
Tue Aug 9 09:56:48 CEST 2022


On Thu,  4 Aug 2022 13:03:44 +0200
Pali Rohár <pali at kernel.org> wrote:

> The device ignores any levels or transitions on the SCL pin when the device
> is idle, asleep or during waking up.
> 
> Linux kernel driver for atsha204a (atmel-sha204a.ko) also ignores return
> value from i2c wakeup send command, see:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/crypto/atmel-i2c.c?h=v5.19#n174
> 
> And also userspace Turris libatsha204 library ignores return value from
> wakeup send command, see:
> https://gitlab.nic.cz/turris/libatsha204/-/blob/v29.2/src/libatsha204/layer_ni2c.c#L75-76
> 
> U-Boot driver should do same thing.
> 
> Fixes waking up ATSHA204 on Turris 1.x boards.
> 
> Signed-off-by: Pali Rohár <pali at kernel.org>

Reviewed-by: Marek Behún <kabel at kernel.org>

Stefan, will you apply this via marvell?


More information about the U-Boot mailing list