[PATCH 7/7] fdt: Move to setuptools

Tom Rini trini at konsulko.com
Tue Aug 9 22:11:32 CEST 2022


On Tue, Aug 09, 2022 at 01:51:15PM -0600, Simon Glass wrote:
> Hi Tom,
> 
> On Tue, 9 Aug 2022 at 11:56, Tom Rini <trini at konsulko.com> wrote:
> >
> > On Sat, Jul 30, 2022 at 08:57:11PM -0600, Simon Glass wrote:
> >
> > > The distutils package is deprecated. The upstream libfdt repo uses
> > > setuptools for building the pylibfdt module, so bring in that code,
> > > suitably modified for U-Boot. Also bring in the README.
> > >
> > > The modifications include setting the version correctly, making use of
> > > the environment variables provided by the Makefile and various tweaks
> > > to the directories.
> > >
> > > Note that the version omits the minus character at the start of
> > > EXTRAVERSION, since this creates a warning. The build is really just used
> > > within U-Boot itself, so it doesn't matter too much if the version matches
> > > upstream, or exactly matches U-Boot.
> > >
> > > Signed-off-by: Simon Glass <sjg at chromium.org>
> > > ---
> > >
> > >  scripts/dtc/README            | 106 ++++++++++++++++++++++++++++++++++
> > >  scripts/dtc/pylibfdt/Makefile |   5 +-
> > >  scripts/dtc/pylibfdt/setup.py |  60 ++++++++++++++++---
> > >  3 files changed, 161 insertions(+), 10 deletions(-)
> > >  create mode 100644 scripts/dtc/README
> >
> > This isn't new enough, however:
> > /usr/lib/python3/dist-packages/setuptools/installer.py:27:
> > SetuptoolsDeprecationWarning: setuptools.installer is deprecated.
> > Requirements should be satisfied by a PEP 517 installer.
> > when trying in Ubuntu 22.04 (the
> > trini/u-boot-gitlab-ci-runner:jammy-20220531-13Jul2022 docker specifically).
> 
> +Rob Herring
> 
> Yes I see that. But it is a start!
> 
> Also I was about to send a pull request with this...should I take it out?

Well, it brings us in sync with upstream I see, so yes, we should take
this now and work on getting the next warning resolved. For why I hit
this again, I'm just shuffling around where we set -e/+e.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20220809/cfdc969e/attachment.sig>


More information about the U-Boot mailing list