[PATCH 21/23] blk: Switch over to using uclass IDs

[Simon Glass]

Hi Takahiro,

On Sun, 7 Aug 2022 at 19:05, AKASHI Takahiro <takahiro.akashi at linaro.org> wrote:
>
> My comment below is not directly related to the change, but
>
> On Sun, Aug 07, 2022 at 09:47:06AM -0600, Simon Glass wrote:
> > We currently have an if_type (interface type) and a uclass id. These are
> > closely related and we don't need to have both.
> >
> > Drop the if_type values and use the uclass ones instead.
> >
> > Maintain the existing, subtle, one-way conversion between UCLASS_USB and
> > UCLASS_MASS_STORAGE for now, and add a comment.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> >  .../mach-stm32mp/cmd_stm32prog/stm32prog.c    |  4 +-
> >  board/toradex/common/tdx-cfg-block.c          |  4 +-
> >  cmd/bcb.c                                     |  4 +-
> >  cmd/ide.c                                     |  2 +-
> >  cmd/mmc.c                                     |  8 +--
> >  cmd/mvebu/bubt.c                              |  2 +-
> >  cmd/nvme.c                                    |  4 +-
> >  cmd/pvblock.c                                 |  2 +-
> >  cmd/sata.c                                    |  4 +-
> >  cmd/scsi.c                                    |  2 +-
> >  cmd/usb.c                                     |  2 +-
> >  cmd/virtio.c                                  |  2 +-
> >  common/spl/spl_sata.c                         |  2 +-
> >  common/spl/spl_usb.c                          |  2 +-
> >  common/usb_storage.c                          |  8 +--
> >  disk/part.c                                   | 52 ++++++++--------
> >  doc/develop/uefi/uefi.rst                     |  2 +-
> >  drivers/ata/dwc_ahsata.c                      |  2 +-
> >  drivers/ata/fsl_sata.c                        |  2 +-
> >  drivers/ata/sata.c                            |  2 +-
> >  drivers/ata/sata_mv.c                         |  2 +-
> >  drivers/ata/sata_sil.c                        |  2 +-
> >  drivers/block/blk-uclass.c                    | 62 ++++++++++---------
> >  drivers/block/efi_blk.c                       |  2 +-
> >  drivers/block/ide.c                           |  8 +--
> >  drivers/block/sandbox.c                       | 12 ++--
> >  drivers/dfu/dfu_mmc.c                         |  6 +-
> >  drivers/mmc/mmc-uclass.c                      | 10 +--
> >  drivers/mmc/mmc_legacy.c                      |  6 +-
> >  drivers/mmc/mmc_write.c                       |  4 +-
> >  drivers/nvme/nvme.c                           |  2 +-
> >  drivers/scsi/scsi.c                           | 10 +--
> >  drivers/tee/optee/rpmb.c                      |  4 +-
> >  drivers/virtio/virtio_blk.c                   |  4 +-
> >  drivers/xen/pvblock.c                         |  6 +-
> >  env/mmc.c                                     |  4 +-
> >  include/blk.h                                 | 18 +-----
> >  include/mmc.h                                 |  2 +-
> >  lib/efi_driver/efi_block_device.c             |  4 +-
> >  lib/efi_loader/efi_disk.c                     |  4 +-
> >  test/dm/blk.c                                 | 24 +++----
> >  41 files changed, 150 insertions(+), 158 deletions(-)
> >


> > diff --git a/disk/part.c b/disk/part.c
> > index 2bcc6f4f403..75aff7eba5a 100644
> > --- a/disk/part.c
> > +++ b/disk/part.c
> > @@ -121,34 +121,34 @@ void dev_print (struct blk_desc *dev_desc)
> >       }
>
> This function misses out the case of IF_TYPE_EFI_MEDIA and fails to handle it.

OK I will add a patch for it.

Regards,
Simon