[RFC PATCH v4 26/28] for test purpose only: Comment out dollar tests which prints error messages.

Francis Laniel francis.laniel at amarulasolutions.com
Fri Aug 12 23:12:23 CEST 2022


Le vendredi 17 juin 2022, 16:02:35 CEST Tom Rini a écrit :
> On Fri, Jun 17, 2022 at 12:31:56AM +0200, Francis Laniel wrote:
> > Error messages like "unknown command" will make the CI fails.
> > So, for the moment, we comment these tests.
> > 
> > Signed-off-by: Francis Laniel <francis.laniel at amarulasolutions.com>
> 
> Why don't we have the test expect "unknown command" as the output here,
> when on the newer shell?  Or if both shells print that now, in both
> cases?  We want tests for when things are expected to fail.

If you run `ut hush` from U-Boot prompt, this test does not fail (I added the 
failure on purpose to test that it should fail).
But when run from the CI, it is run within test.py which checks from "unknown 
command" to not be present in the output [1].

I am not really familiar with the python testing framework but I think I can 
find another solution using disable_check() when running this test with 2021 
shell.

---
[1] https://elixir.bootlin.com/u-boot/v2022.07/source/test/py/
u_boot_console_base.py#L35




More information about the U-Boot mailing list