[PATCH v2 10/10] binman: Add zstd bintool

[Simon Glass]

Hi Stefan,

On Mon, 8 Aug 2022 at 04:52, Stefan Herbrechtsmeier
<stefan.herbrechtsmeier-oss at weidmueller.com> wrote:
>
> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier at weidmueller.com>
>
> Add zstd bintool to binman to support on-the-fly compression.
>
> Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier at weidmueller.com>
>
> ---
>
> Changes in v2:
> - Added
>
>  tools/binman/btool/zstd.py     | 30 ++++++++++++++++++++++++++++++
>  tools/binman/comp_util.py      | 18 +++++++++---------
>  tools/binman/etype/blob_dtb.py |  4 ++++
>  tools/binman/ftest.py          |  3 ++-
>  4 files changed, 45 insertions(+), 10 deletions(-)
>  create mode 100644 tools/binman/btool/zstd.py

Reviewed-by: Simon Glass <sjg at chromium.org>

But as you noted this does cause CI issues:

ERROR: binman.ftest.TestFunctional.testCompressions (subunit.RemotedTestCase)
binman.ftest.TestFunctional.testCompressions
----------------------------------------------------------------------
testtools.testresult.real._StringException: Traceback (most recent call last):
TypeError: a bytes-like object is required, not 'NoneType'
======================================================================
FAIL: binman.ftest.TestFunctional.testVersions (subunit.RemotedTestCase)
binman.ftest.TestFunctional.testVersions
----------------------------------------------------------------------
testtools.testresult.real._StringException: stdout: {{{
bzip2 - 1.0.8
gzip - 1.10
lz4 - v1.9.2
lzma - 9.22 beta
lzo - v1.04
xz - 5.2.4
zstd - unknown
}}}
Traceback (most recent call last):
AssertionError: Regex didn't match: '^v?[0-9]+[0-9.]*' not found in 'unknown'

One option is to check if zstd is available, using is_present() in
your testCompressions() function.

Regards,
Simon