[PATCH v2 05/10] binman: Add BintoolPacker class to bintool

[Stefan Herbrechtsmeier]

Hi Simon,

Am 13.08.2022 um 16:59 schrieb Simon Glass:
> Hi Stefan,
> 
> On Mon, 8 Aug 2022 at 04:51, Stefan Herbrechtsmeier
> <stefan.herbrechtsmeier-oss at weidmueller.com> wrote:
>>
>> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier at weidmueller.com>
>>
>> Add a bintools base class for packers which compression / decompression
>> entry contents.
>>
>> Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier at weidmueller.com>
>>
>> ---
>>
>> Changes in v2:
>> - Added
>>
>>   tools/binman/bintool.py | 94 +++++++++++++++++++++++++++++++++++++++++
>>   1 file changed, 94 insertions(+)
>>
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> The one strange thing about this is that we don't support these
> compression tools being missing, as we do with other tools. If 'lz4'
> is needed and not present, binman just fails. This predates your
> change, but I just noticed it.
> 
> I think this is OK though, at least for now. We could handle a missing
> algo by returning empty data and marking the entry as 'missing', but I
> don't see a great need for it at present. The compression tools are
> widely available and easy to install.

I have add a commit to the series for it.