[PATCH v4 03/13] binman: Disable compressed data header

[Simon Glass]

Hi Stefan,

On Tue, 16 Aug 2022 at 06:03, Stefan Herbrechtsmeier
<stefan.herbrechtsmeier-oss at weidmueller.com> wrote:
>
> Hi Simon,
>
> Am 16.08.2022 um 13:48 schrieb Simon Glass:
> > Hi Stefan,
> >
> > On Tue, 16 Aug 2022 at 02:42, Stefan Herbrechtsmeier
> > <stefan.herbrechtsmeier-oss at weidmueller.com> wrote:
> >>
> >> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier at weidmueller.com>
> >>
> >> Disable the compressed data header of the utilities to compress and
> >> decompress data. The header is uncommon, not supported by U-Boot and
> >> incompatible with external compressed artifacts.
> >>
> >> The header was introduced as part of commit eb0f4a4cb402 ("binman:
> >> Support replacing data in a cbfs") to allow device tree entries to be
> >> larger than the compressed contents.
> >>
> >> Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier at weidmueller.com>
> >>
> >> ---
> >>
> >> (no changes since v3)
> >>
> >> Changes in v3:
> >> - Added
> >>
> >>   tools/binman/entry.py         |  2 +-
> >>   tools/binman/etype/section.py |  3 ++-
> >>   tools/binman/ftest.py         | 18 +++++++++++-------
> >>   3 files changed, 14 insertions(+), 9 deletions(-)
> >
> > This seems strange to me.
> >
> > I would expect this patch to make every call set with_header to False,
> > then the next patch remove the parameters. That would allow later
> > bisecting to see where a problem occurs.
> >
> > But at present this patch and the next seem to be mixed together.
>
> I skipped the following calls because it doesn't matter:
> comp_util.compress(b'',  'invalid')
> comp_util.decompress(b'1234', 'invalid')

I still think it is worth it, because the default is True.

>
> Do I miss a call?

Everything should pass False in this patch I think.

>
> The cbfs_util.py file doesn't use the header.
OK

Regards,
SImon