[PATCH v2 3/6] cmd: fru: fix a sandbox segfault issue
Jae Hyun Yoo
quic_jaehyoo at quicinc.com
Tue Aug 16 23:40:17 CEST 2022
Hi Simon,
On 8/16/2022 1:42 PM, Simon Glass wrote:
[...]
>
> Reviewed-by: Simon Glass <sjg at chromium.org>
>
Thanks for your review!
[...]
>> int fru_display(int verbose);
>> -int fru_capture(unsigned long addr);
>> -int fru_generate(unsigned long addr, int argc, char *const argv[]);
>> +int fru_capture(const void *addr);
>> +int fru_generate(const void *addr, int argc, char *const argv[]);
>
> Please add proper comments to these here.
Sure. I'll add comments to describe these prototypes in the next spin.
Thanks,
Jae
More information about the U-Boot
mailing list