[PATCH] Makefile: Unify condition for mpc85xx reset vector

Pali Rohár pali at kernel.org
Thu Aug 18 09:56:26 CEST 2022


On Wednesday 17 August 2022 19:13:08 Simon Glass wrote:
> On Wed, 3 Aug 2022 at 15:57, Pali Rohár <pali at kernel.org> wrote:
> >
> > Use 'CONFIG_MPC85XX_HAVE_RESET_VECTOR && CONFIG_OF_SEPARATE' pattern
> > instead of 'CONFIG_MPC85XX_HAVE_RESET_VECTOR && !CONFIG_OF_EMBED' also in
> > OBJCOPYFLAGS_u-boot-nodtb.bin as this pattern is used in rest of Makefile.
> >
> > Signed-off-by: Pali Rohár <pali at kernel.org>
> > ---
> >  Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> Let's make a plan to move this to binman at some point.
> 

Once all mpc pending patches which are waiting there for months are
reviewed and merged, I can try to look at it. Until that I'm stopping
any development in this area. Ball is _not_ on my side.

> 
> >
> > diff --git a/Makefile b/Makefile
> > index d659c8118cba..23bf0c8b1e62 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1267,7 +1267,7 @@ spl/u-boot-spl.srec: spl/u-boot-spl FORCE
> >
> >  OBJCOPYFLAGS_u-boot-nodtb.bin := -O binary \
> >                 $(if $(CONFIG_X86_16BIT_INIT),-R .start16 -R .resetvec) \
> > -               $(if $(CONFIG_MPC85XX_HAVE_RESET_VECTOR),$(if $(CONFIG_OF_EMBED),,-R .bootpg -R .resetvec))
> > +               $(if $(CONFIG_MPC85XX_HAVE_RESET_VECTOR),$(if $(CONFIG_OF_SEPARATE),-R .bootpg -R .resetvec))
> >
> >  binary_size_check: u-boot-nodtb.bin FORCE
> >         @file_size=$(shell wc -c u-boot-nodtb.bin | awk '{print $$1}') ; \
> > --
> > 2.20.1
> >


More information about the U-Boot mailing list