Fix KWBOOT_MSG_RSP_TIMEO_AXP in kwboot for Armada XP

[Pali Rohár]

On Friday 19 August 2022 09:30:55 Stefan Roese wrote:
> Hi Pali,
> 
> On 16.08.22 20:41, Pali Rohár wrote:
> > On Wednesday 01 June 2022 12:54:28 Pali Rohár wrote:
> > > On Wednesday 01 June 2022 12:44:01 Stefan Roese wrote:
> > > > Hi Pali,
> > > > 
> > > > On 01.06.22 12:27, Pali Rohár wrote:
> > > > > On Friday 06 May 2022 14:44:48 Pali Rohár wrote:
> > > > > > On Friday 06 May 2022 14:35:55 Stefan Roese wrote:
> > > > > > > While doing this I noticed though, that kwboot UART booting only worked
> > > > > > > in roughly 1 out of 2 cases. With no progress after this line:
> > > > > > > 
> > > > > > > Sending boot message. Please reboot the target...\
> > > > > > > 
> > > > > > > IIRC, this worked more reliable a few weeks ago. Any idea, what might
> > > > > > > have caused this regression - if I am correct here?
> > > > > > 
> > > > > > There were changes in handling of bootrom boot message. There is option
> > > > > > -s which can change default timeout option. And plus there is option -a
> > > > > > which sets this timeout option to AXP value.
> > > > > > 
> > > > > > Default value is 50 and for AXP default value is 1000.
> > > > > > 
> > > > > > Maybe it is needed to tune AXP value... Try to call with -s option
> > > > > > between 50 and 1000...
> > > > > 
> > > > > Hello Stefan! Have you tried to tune kwboot's -s or -a option for AXP board?
> > > > 
> > > > Thanks for getting back on this. I totally forgot about it.
> > > > 
> > > > '-a' makes it actually worse. Zero success with 5 tries. '-s 10' worked
> > > > 5 out of 5 times. So I'll stick with this version I think.
> > > > 
> > > > Thanks,
> > > > Stefan
> > > 
> > > Ok! So I think that you could change KWBOOT_MSG_RSP_TIMEO_AXP value in
> > > tools/kwboot.c to 10 if it works fine for your AXP board. So '-a' option
> > > would work better.
> > 
> > Hello! I would like to remind this issue. Could you look at it, so we do
> > not have broken '-a' option in kwboot?
> 
> Thanks for the reminder. I've checked again and "-a" is not working
> reliable on my AXP platform (any more?). Using "-s 10" seem to be much
> better.
> 
> So we should either remove this -a option completely or change the
> define to 10 instead of 1000 IMHO.
> 
> Thanks,
> Stefan

Yes, please check also if kwboot is reliable without any -a or -s option
on AXP platform. If it works, then remove/deprecate -a option. If it
does not work and requires specific -s 10 option, then change
KWBOOT_MSG_RSP_TIMEO_AXP macro to 10.