[PATCH 3/5] net: tftp: add IPv6 support for tftpboot

[Vyacheslav Mitrofanov V]

On Fri, 2022-08-19 at 21:01 +0300, Ramon Fried wrote:
> 
> On Fri, Aug 19, 2022 at 2:30 PM Vyacheslav Mitrofanov V
> <v.v.mitrofanov at yadro.com> wrote:
> > On Fri, 2022-08-19 at 14:00 +0300, Ramon Fried wrote:
> > > On Fri, Aug 19, 2022 at 11:10 AM Viacheslav Mitrofanov
> > > <v.v.mitrofanov at yadro.com> wrote:
> > > > The command tftpboot uses IPv4 by default, to use IPv6 instead
> > > > add
> > > > -ipv6
> > > > as the last argument. All other tftpboot features and
> > > > parameters
> > > > are left
> > > > the same.
> > > > 
> > > In my opinion, we should be able to detect if a user has provided
> > > or
> > > set an IPv6 server IP address and only use IPv6 then.
> > I tried to save tftboot semantics. I mean if we set -ipv6 option
> > the
> > command will check server address in args if it is empty check
> > environmental variable and if it is not set then terminate it. It
> > works
> > the same way as it works now. If I didn't get you, please, clarify
> > it a
> > little bit more.
> > Thanks!
> What I meant is that if you can distinguish IPv6 address from just
> parsing the address itself.
> Perhaps the -ipv6 is redundant.
It is not a problem to add a parser, I'll do that.
I thought that suffix can be useful if we use short command notation as
an example just 'tftpboot'. In that case it uses IPv4 but if add suffix
it will use IPv6. Or I can remove suffix at all and use an environment
variable for example 'use_ip6' to determine protocol.
What do you think?!
Thanks!