[RESEND PATCH 1/2] rpi: Copy properties from firmware dtb to the loaded dtb

[Simon Glass]

Hi Antoine,

On Mon, 22 Aug 2022 at 16:00, Antoine Mazeas <antoine at karthanis.net> wrote:
>
> Thanks Simon,
>
> Can I ask you to clarify what you meant by "drop the private firmware"?

Replace the private binary with a full U-Boot implementation. I hope
that the vendor might do it one day.

> For the record, this patch was tested using the vendored firmware from
> Raspberry Pi, v1.20220331, and subsequently v1.20220811 when it came
> out.
>
> I'm happy to do the requested change now if you think it is preferable.

No need, it's fine. We'll keep an eye out for it if someone else uses
your function.

Regards,
Simon


>
> Regards
>
> Le 22/08/2022 à 18:39, Simon Glass a écrit :
> > Hi Antoine,
> >
> > On Fri, 19 Aug 2022 at 08:08, Antoine Mazeas <antoine at karthanis.net> wrote:
> >>
> >> The RPI firmware adjusts several property values in the dtb it passes
> >> to u-boot depending on the board/SoC revision. Inherit some of these
> >> when u-boot loads a dtb itself. Specificaly copy:
> >>
> >> * /model: The firmware provides a more specific string
> >> * /memreserve: The firmware defines a reserved range, better keep it
> >> * emmc2bus and pcie0 dma-ranges: The C0T revision of the bcm2711 Soc (as
> >>    present on rpi 400 and some rpi 4B boards) has different values for
> >>    these then the B0T revision. So these need to be adjusted to boot on
> >>    these boards
> >> * blconfig: The firmware defines the memory area where the blconfig
> >>    stored. Copy those over so it can be enabled.
> >> * /chosen/kaslr-seed: The firmware generates a kaslr seed, take advantage
> >>    of that.
> >>
> >> Signed-off-by: Sjoerd Simons <sjoerd at collabora.com>
> >> Signed-off-by: Antoine Mazeas <antoine at karthanis.net>
> >> ---
> >>
> >>   board/raspberrypi/rpi/rpi.c | 48 +++++++++++++++++++++++++++++++++++++
> >>   1 file changed, 48 insertions(+)
> >
> > Reviewed-by: Simon Glass <sjg at chromium.org>
> >
> > I wonder if anyone has tried to drop the private firmware on the boards?
> >
> > At some point copy_property() should move to fdt_support.c if others use it